Skip to content

Remove obsolete code paths (working subset) #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 10, 2022

Conversation

MrMino
Copy link
Collaborator

@MrMino MrMino commented Nov 9, 2022

Subset of #93

Made on an Android phone (as a challenge 😁), so I still need to review it.

@codecov-commenter
Copy link

Codecov Report

Merging #95 (a2037ed) into master (42294c1) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master       #95   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            7         7           
  Lines          599       598    -1     
=========================================
- Hits           599       598    -1     
Impacted Files Coverage Δ
pip_check_reqs/find_missing_reqs.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@MrMino MrMino force-pushed the obsolete-imports-subset branch 2 times, most recently from 922d5a1 to e485078 Compare November 9, 2022 13:18
@MrMino MrMino changed the title Obsolete imports subset Remove obsolete code paths Nov 9, 2022
We are now constrained on `pip >= 21.2.4` (bcfd93c). This commit
elliminates code paths that were there previously in order to cater to
the older versions of Pip:

- `PipSession` is now only found in `pip._internal._network.session`.
- `install_req_from_line` is always used.
@MrMino MrMino force-pushed the obsolete-imports-subset branch from e485078 to 2c12ce5 Compare November 10, 2022 00:19
@MrMino MrMino changed the title Remove obsolete code paths Remove obsolete code paths (working subset) Nov 10, 2022
@MrMino MrMino marked this pull request as ready for review November 10, 2022 00:20
@MrMino MrMino merged commit 8e7b033 into adamtheturtle:master Nov 10, 2022
@MrMino MrMino deleted the obsolete-imports-subset branch November 10, 2022 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants